Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ProductVariant] Rename options to optionValues #6236

Merged
merged 1 commit into from
Sep 28, 2016
Merged

[ProductVariant] Rename options to optionValues #6236

merged 1 commit into from
Sep 28, 2016

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Sep 28, 2016

Q A
Bug fix? no
New feature? no
BC breaks? yes
Related tickets
License MIT

@pjedrzejewski pjedrzejewski added BC Break PRs introducing BC breaks (do not even try to merge). DX Issues and PRs aimed at improving Developer eXperience. labels Sep 28, 2016
pamil
pamil approved these changes Sep 28, 2016
View reviewed changes
Copy link
Contributor

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@michalmarcinkowski michalmarcinkowski merged commit 36c5800 into Sylius:master Sep 28, 2016
@michalmarcinkowski
Copy link
Contributor

Thanks Grzesiu! 👍

@Koc
Copy link

Koc commented Sep 28, 2016

No upgrade note?

@michalmarcinkowski
Copy link
Contributor

Good catch Konstantin! @GSadee could you also add a note in upgrade file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
BC Break PRs introducing BC breaks (do not even try to merge). DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@GSadee @michalmarcinkowski @Koc @pamil @pjedrzejewski