Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Remove admin root path #6253

Merged
merged 1 commit into from
Oct 1, 2016
Merged

[Admin] Remove admin root path #6253

merged 1 commit into from
Oct 1, 2016

Conversation

lchrusciel
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? yes
Related tickets
License MIT

@emodric
Copy link
Contributor

emodric commented Sep 30, 2016

Won't this make /admin/ to stop working?

#6252 fixes /admin, but I guess you'd still want /admin/ to keep on working, right?

@lchrusciel
Copy link
Member Author

No. Both sylius_admin_root and sylius_admin_dashboard_redirect redirects to the same action sylius_admin_dashboard. So #6252 needs only sylius_admin_dashboard to work.

@emodric
Copy link
Contributor

emodric commented Sep 30, 2016

Sure, I get that, but if you remove this route, wouldn't /admin/ (with trailing slash) become 404, so no redirect at all to sylius_admin_dashboard would happen?

@emodric
Copy link
Contributor

emodric commented Sep 30, 2016

Forget it, I somehow missed the line where you renamed /dashboard to just / :)

@pjedrzejewski pjedrzejewski merged commit 73758d3 into Sylius:master Oct 1, 2016
@pjedrzejewski
Copy link
Member

Thank you Łukasz!

@lchrusciel lchrusciel deleted the routing-cleaning branch October 1, 2016 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lchrusciel @emodric @pjedrzejewski