-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Payum] Use converted amount for generic capture #6275
Conversation
inssein
commented
Oct 4, 2016
Q | A |
---|---|
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Related tickets | partially #6258 |
License | MIT |
* | ||
* @return float | ||
*/ | ||
private function convertAndFormatPrice($price, $currencyCode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think convertPrice
would be fine :)
$payumPayment->setTotalAmount($order->getTotal()); | ||
$payumPayment->setTotalAmount( | ||
$this->convertAndFormatPrice($order->getTotal(), $order->getCurrencyCode()) | ||
); | ||
$payumPayment->setCurrencyCode($order->getCurrencyCode()); | ||
$payumPayment->setClientEmail($order->getCustomer()->getEmail()); | ||
$payumPayment->setClientId($order->getCustomer()->getId()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also fix the total that is included in the description (not visible in this diff, it's below this line).
@michalmarcinkowski done :) |
@Arminek does it look good? |
👍 |
Thanks Hussein! :) |