[Resource] Moved flash translation from helper to template #6277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Oct 4, 2016
•
NoResponseMate
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | yes |
| Related tickets | - |
| License | MIT |
NoResponseMate
changed the title
NoResponseMate
force-pushed
the
fix/flash-helper
branch
3 times, most recently
from
a1dc441
to
ae5462b
Compare
NoResponseMate
changed the title
NoResponseMate
force-pushed
the
fix/flash-helper
branch
2 times, most recently
from
227e75f
to
99e24be
Compare
pjedrzejewski
approved these changes
Oct 5, 2016
pamil
reviewed
Oct 5, 2016
| if ($flashMessage === $translatedMessage) { | ||
| $translatedMessage = $this->translateMessage(sprintf('sylius.resource.%s', $actionName), $metadata); | ||
| if ($this->isResourceDefaultMessage($message, $metadata->getName(), $actionName)) { | ||
| $message = $this->getResourceMessage($actionName); |
There was a problem hiding this comment.
- We've got a message
sylius.customer.update - It happens to be the resource default message
- We replace it with
sylius.resource.update - No profit, wtf?
NoResponseMate
force-pushed
the
fix/flash-helper
branch
from
99e24be
to
f0a8c2d
Compare
lchrusciel
approved these changes
Oct 6, 2016
NoResponseMate
force-pushed
the
fix/flash-helper
branch
from
f0a8c2d
to
62aaf3c
Compare
NoResponseMate
force-pushed
the
fix/flash-helper
branch
from
62aaf3c
to
8781d52
Compare
|
Thank you Jasiek! :) |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Resource] Moved flash translation from helper to template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.