Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused set*(Collection) methods on models #6327

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Oct 6, 2016

Q A
Bug fix? no
New feature? no
BC breaks? yes
Related tickets fixes #6314
License MIT

@pjedrzejewski pjedrzejewski added the BC Break PRs introducing BC breaks (do not even try to merge). label Oct 6, 2016
@pamil pamil force-pushed the refactor/remove-set-collection-methods branch 3 times, most recently from 9238313 to 43ebbfb Compare October 6, 2016 20:11
@pjedrzejewski
Copy link
Member

Requires a rebase.

@pjedrzejewski
Copy link
Member

Wrong button, sorry. :P

@pamil pamil force-pushed the refactor/remove-set-collection-methods branch from 43ebbfb to f573f93 Compare October 7, 2016 09:15
@pamil pamil force-pushed the refactor/remove-set-collection-methods branch from f573f93 to 95b71f7 Compare October 7, 2016 09:56
@michalmarcinkowski michalmarcinkowski merged commit aa2581b into Sylius:master Oct 9, 2016
@michalmarcinkowski
Copy link
Contributor

👍

@pamil pamil deleted the refactor/remove-set-collection-methods branch October 9, 2016 10:46
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
…ion-methods

Remove unused set*(Collection) methods on models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break PRs introducing BC breaks (do not even try to merge).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Remove set*(Collection) methods on models
3 participants