[Promotion] Rename Action(Interface) to PromotionAction(Interface) #6330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjedrzejewski
added
the
BC Break
pamil
force-pushed
the
promotion/model-renaming
branch
from
6bd6109
to
b15cd5f
Compare
pamil
force-pushed
the
promotion/model-renaming
branch
from
b15cd5f
to
1fe7e30
Compare
|
👍 |
|
We were discussing the name "Command", I think it makes the class names way too long and complicated. |
|
Do we have any alternative? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was forced to come up with a new name for
Sylius\Component\Promotion\Action\PromotionActionInterfaceas they will collide with renamed model interface. I thinkSylius\Component\Promotion\Action\PromotionActionCommandInterfacedescribes it better.