[Admin] Disable toggling of base currency #6354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Oct 7, 2016
NoResponseMate
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | yes |
| Related tickets | - |
| License | MIT |
pamil
suggested changes
Oct 7, 2016
| { | ||
| parent::buildForm($builder, $options); | ||
|
|
||
| $builder->addEventListener(FormEvents::PRE_SET_DATA, function(FormEvent $event) { |
There was a problem hiding this comment.
function(...) -> function (...) 🎉
| /** | ||
| * @author Jan Góralski <jan.goralski@lakion.com> | ||
| */ | ||
| class CannotDisableCurrency extends Constraint |
| /** | ||
| * @author Jan Góralski <jan.goralski@lakion.com> | ||
| */ | ||
| class CannotDisableCurrencyValidator extends ConstraintValidator |
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function validate($currency, Constraint $constraint) |
There was a problem hiding this comment.
Missing assertion that $currency is instance of CurrencyInterface.
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function validate($currency, Constraint $constraint) |
There was a problem hiding this comment.
Missing assertion that $constraint is instance of CannotDisableCurrency.
| if ($currency->getCode() !== $this->baseCurrency) { | ||
| return; | ||
| } | ||
| if ($currency->isEnabled()) { |
| /** | ||
| * @author Jan Góralski <jan.goralski@lakion.com> | ||
| */ | ||
| class CurrencyType extends BaseCurrencyType |
There was a problem hiding this comment.
Btw. I guess we can achieve the same result by using form type extensions instead of custom type. It will be also a lot cleaner.
NoResponseMate
force-pushed
the
admin/disable-toggling-base-currency
branch
from
c31889c
to
9712adb
Compare
| Scenario: | ||
| Given the store operates on a single channel | ||
| And it uses the "USD" currency by default | ||
| And I want to edit this currency |
NoResponseMate
force-pushed
the
admin/disable-toggling-base-currency
branch
from
9712adb
to
4fc11a0
Compare
NoResponseMate
force-pushed
the
admin/disable-toggling-base-currency
branch
from
4fc11a0
to
c3ab499
Compare
|
Thanks Jasiek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.