Fix Customer Group Type and RuleChecker #6374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,11 @@ public function isEligible(PromotionSubjectInterface $subject, array $configurat | |||
| return false; | |||
| } | |||
|
|
|||
| if ($configuration['groups'] === $customer->getGroup()->getId()) { | |||
| if (is_null($customer->getGroup())) { | |||
There was a problem hiding this comment.
We have the following convention for checking for null value: if (null === $customer->getGroup()) {
| return false; | ||
| } | ||
|
|
||
| if ($configuration['group'] === $customer->getGroup()->getId()) { |
There was a problem hiding this comment.
We should use code, same as we do in TaxonRuleChecker (can be done in a separate PR).
|
Thanks @tchapi! Regarding using the code, we can handle that in a separate PR or when covering this functionality with scenarios. |
|
Yes, that's what I thought too because it's not really related to this PR in particular |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…le-checker Fix Customer Group Type and RuleChecker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the CustomerGroupType and RuleChecker