Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SettingsBundle] Fix service name #6430

Merged
merged 1 commit into from
Oct 17, 2016
Merged

[SettingsBundle] Fix service name #6430

merged 1 commit into from
Oct 17, 2016

Conversation

tuka217
Copy link
Contributor

@tuka217 tuka217 commented Oct 17, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets #6428
License MIT

@tuka217 tuka217 changed the title [SettingsBundle] Fix service name [WIP][SettingsBundle] Fix service name Oct 17, 2016
pamil
pamil reviewed Oct 17, 2016
View reviewed changes
Copy link
Contributor

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sylius.settings.manager -> sylius.settings_manager, wdyt?

@tuka217 tuka217 changed the title [WIP][SettingsBundle] Fix service name [SettingsBundle] Fix service name Oct 17, 2016
@tuka217
Copy link
Contributor Author

tuka217 commented Oct 17, 2016

@pamil why not.

@tuka217 tuka217 changed the title [SettingsBundle] Fix service name [WIP][SettingsBundle] Fix service name Oct 17, 2016
@tuka217 tuka217 changed the title [WIP][SettingsBundle] Fix service name [SettingsBundle] Fix service name Oct 17, 2016
@michalmarcinkowski michalmarcinkowski merged commit 19fd0a8 into Sylius:master Oct 17, 2016
@michalmarcinkowski
Copy link
Contributor

Thanks Ania!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tuka217 @michalmarcinkowski @pamil @pjedrzejewski