[SettingsBundle][Registry] Remove final, because classes must be proxied #6434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tuka217
commented
Oct 17, 2016
tuka217
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Related tickets | - |
| License | MIT |
pamil
reviewed
Oct 17, 2016
| * @author Paweł Jędrzejewski <pawel@sylius.org> | ||
| */ | ||
| final class ServiceRegistry implements ServiceRegistryInterface | ||
| class ServiceRegistry implements ServiceRegistryInterface |
There was a problem hiding this comment.
Is it really needed for Registry's ServiceRegistry as well? Making only Settings' ResolverSettingsRegistry not final should work.
There was a problem hiding this comment.
Let's verify this properly and revert if we will be confirmed it doesn't break anything.
|
Thanks Ania! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.