Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoreBundle][DX] Division of the state_machine.yml file #6448

Merged
merged 2 commits into from
Oct 18, 2016

Conversation

CoderMaggie
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Related tickets
License MIT

In order to make the customization of state machines easier we have divided the giant state_machine.yml file into several smaller.

@michalmarcinkowski michalmarcinkowski added the DX Issues and PRs aimed at improving Developer eXperience. label Oct 18, 2016
to: rejected
callbacks:
after:
update_price:
Copy link
Contributor

@michalmarcinkowski michalmarcinkowski Oct 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's not related to your changes, but I think it should be update_rating :)

Copy link
Member Author

@CoderMaggie CoderMaggie Oct 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally true. But should I change it here? /cc @pjedrzejewski

@pjedrzejewski pjedrzejewski merged commit 554339f into Sylius:master Oct 18, 2016
@pjedrzejewski
Copy link
Member

Thanks Magda! :)

@CoderMaggie CoderMaggie deleted the state-machines-division branch January 17, 2017 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants