Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cart] Fix cart summary display #6478

Merged
merged 2 commits into from
Oct 20, 2016
Merged

[Cart] Fix cart summary display #6478

merged 2 commits into from
Oct 20, 2016

Conversation

michalmarcinkowski
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets fixes #6267
License MIT

@pjedrzejewski
Copy link
Member

Are you sure? This will be quite confusing. It won't include shipping? Or we have wrong implementation of subtotal. Subtotal should only items, without shipping, etc.

@michalmarcinkowski
Copy link
Contributor Author

It's OrderItem::subTotal not Order::subTotal. It returns discountedUnitPrice * quantity while OrderItem::total returns also distributed order promotions which causes the confusing display (see #6267).

@pjedrzejewski pjedrzejewski merged commit abce458 into Sylius:master Oct 20, 2016
@pjedrzejewski
Copy link
Member

Ahhh, perfect! Thanks Michał! :)

@michalmarcinkowski michalmarcinkowski deleted the fix-cart-summary-display branch November 26, 2016 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Shop] Wrong total on order item with discounts
2 participants
@michalmarcinkowski @pjedrzejewski