[RFC] [Promotion] Finalize promotion classes in core #6502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lchrusciel
commented
Oct 21, 2016
lchrusciel
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | yes |
| Related tickets | |
| License | MIT |
|
At least we haven't got a commit per each finalised class 🎉 |
lchrusciel
changed the title
lchrusciel
force-pushed
the
finalize-promotion
branch
from
22418f6
to
9f7b0b6
Compare
lchrusciel
force-pushed
the
finalize-promotion
branch
from
9f7b0b6
to
c0f5c4d
Compare
|
What is the preferred way of extending/altering behavior of these classes after this change? |
|
Thank you Łukasz! @patrick-mcdougle Decoration or providing your own implementation. |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[RFC] [Promotion] Finalize promotion classes in core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.