Move punctuation inside translations #6520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spanish translations should not be modified here as they will not be synced. /cc @pamil WDYT? |
|
They need to be changed on CrowdIn. |
patrick-mcdougle
force-pushed
the
fixes-6513
branch
from
fbf191f
to
8d62a11
Compare
|
Updated. |
|
@patrick-mcdougle please rebase |
Conflicts: src/Sylius/Bundle/UiBundle/Resources/translations/messages.en.yml
|
@michalmarcinkowski merge quick before someone adds another translation! Also, I have the maintainer box checked, so you can merge master into this branch to resolve the merge conflicts. (I only work on open source on the weekends, and I know that that can slow things down). |
|
Thanks Patrick! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only modified translation files in which I knew the language sufficiently well. Translators for this software will have to do whatever is required of the other languages to denote questions and exclamations.
I used the following case insensitive regex to search for the occurrences:
I also added quotes to all the strings in the english file. Figured I'd enforce consistency while I was in there.
NOTE: There was a tricky place in the code that I didn't replace which was where the translation was in the database. I wasn't sure what to do so I left it. REF: https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/ShopBundle/Resources/views/Homepage/Menu/_security.html.twig#L3
Perhaps these need to be translation blocks instead?