Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Changed shipping/billing address into defaultAddress on customer's model #6531

Merged
merged 2 commits into from
Oct 24, 2016

Conversation

NoResponseMate
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Related tickets -
License MIT

@NoResponseMate NoResponseMate changed the title [Customer] Changed shipping/billing address into defaultAddress on customer's model [Core] Changed shipping/billing address into defaultAddress on customer's model Oct 24, 2016
@pjedrzejewski pjedrzejewski added BC Break PRs introducing BC breaks (do not even try to merge). New Feature labels Oct 24, 2016
@tchapi
Copy link
Contributor

tchapi commented Oct 24, 2016

Why removing this functionality ? If you are a recurrent customer, you are more than likely to want to have your default billing and shipping address stored for good if they are different, no ?

@pjedrzejewski pjedrzejewski merged commit bc2ce11 into Sylius:master Oct 24, 2016
@pjedrzejewski
Copy link
Member

Thanks Jasiek!

@tchapi We need to simplify this for now, you can easily implement more than 1 default address, but for core we decided to use 1, at least in the first version.

@NoResponseMate NoResponseMate deleted the default-address branch October 24, 2016 20:21
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
[Core] Changed shipping/billing address into defaultAddress on customer's model
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
[Core] Changed shipping/billing address into defaultAddress on customer's model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break PRs introducing BC breaks (do not even try to merge).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants