Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Behat][ProductAssociation] Minor fixes in ShowPage #6581

Merged
merged 1 commit into from
Oct 31, 2016
Merged

[Behat][ProductAssociation] Minor fixes in ShowPage #6581

merged 1 commit into from
Oct 31, 2016

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Oct 28, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets #6564
License MIT

michalmarcinkowski
michalmarcinkowski reviewed Oct 28, 2016
View reviewed changes
src/Sylius/Behat/Page/Shop/Product/ShowPage.php
return false;
}

return true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we have $this->hasElement() method which should be used here :)

@michalmarcinkowski michalmarcinkowski merged commit a687ee2 into Sylius:master Oct 31, 2016
@michalmarcinkowski
Copy link
Contributor

Thanks Grzesiu!

@GSadee GSadee deleted the associated-items-fixes branch September 22, 2017 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalmarcinkowski michalmarcinkowski michalmarcinkowski left review comments

@Zales0123 Zales0123 Zales0123 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GSadee @michalmarcinkowski @Zales0123 @lchrusciel