[Shop][Account] Marking an address as default #6584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tuka217
commented
Oct 28, 2016
tuka217
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Related tickets | #6573 |
| License | MIT |
Zales0123
reviewed
Oct 28, 2016
| Assert::same( | ||
| $fullName, | ||
| $actualFullName, | ||
| sprintf('The default address should be of "%s", but is of "%s".', $fullName, $actualFullName) |
There was a problem hiding this comment.
What about 'The default address should be "%2$s", but it "%s".'?
Zales0123
reviewed
Oct 28, 2016
| private $addressRepository; | ||
|
|
||
| /** | ||
| * @param RepositoryInterface $addressRepository |
There was a problem hiding this comment.
Why not typehint AddressRepositoryInterface?
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.