[Admin][Customer] Seeing detailed information about customer #6596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tuka217
commented
Oct 31, 2016
tuka217
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Related tickets | - |
| License | MIT |
tuka217
changed the title
pamil
suggested changes
Oct 31, 2016
| Scenario: Seeing information about customer groups | ||
| Given the customer belongs to group "Retail" | ||
| When I view details of the customer "f.baggins@shire.me" | ||
| Then I should see the group "Retail" |
There was a problem hiding this comment.
I should see that this customer belongs to the "Retail" group?
| @@ -17,20 +22,29 @@ | |||
| {% endif %} | |||
| {{ 'sylius.ui.subscribed_to_newsletter'|trans }} | |||
| </div> | |||
| <div id="email-verified"> | |||
| {% if customer.user.verified %} | |||
There was a problem hiding this comment.
Can we make this if inline? {{ customer.user.verified ? 'green checkmark' : 'red remove' }}
| @@ -79,6 +79,7 @@ sylius: | |||
| backorder: 'Backorder' | |||
| backordered: 'Backordered' | |||
| balance_due: 'Balance due' | |||
| belonging_to_group: 'Belonging to group: ' | |||
There was a problem hiding this comment.
We shouldn't include : in the translation.
tuka217
force-pushed
the
customer-detail-page
branch
2 times, most recently
from
0e1fa7f
to
fb9185e
Compare
tuka217
changed the title
[UiBandle] Add translations
tuka217
force-pushed
the
customer-detail-page
branch
from
fb9185e
to
90b4dcc
Compare
Arminek
reviewed
Nov 2, 2016
| {{ 'sylius.ui.subscribed_to_newsletter'|trans }} | ||
| </div> | ||
| {% if customer.user %} |
There was a problem hiding this comment.
How about customer.user is defined?
| @@ -7,30 +7,37 @@ | |||
| </a> | |||
| <div class="meta"> | |||
| <span class="date">{{ 'sylius.ui.customer_since'|trans }} {{ customer.createdAt|date }}</span> | |||
| <br /> | |||
| {% if customer.group %} | |||
There was a problem hiding this comment.
But it should be !== null, because when variable is null then it's been already defined, WDYT?
| {{ 'sylius.ui.email_verified'|trans }} | ||
| </div> | ||
| {% endif %} | ||
| {% if customer.defaultAddress %} |
| @@ -79,6 +79,7 @@ sylius: | |||
| backorder: 'Backorder' | |||
| backordered: 'Backordered' | |||
| balance_due: 'Balance due' | |||
| belonging_to_group: 'Belonging to group' | |||
There was a problem hiding this comment.
I meant "membership", so maybe it should be a " belongingness to groups"?
There was a problem hiding this comment.
Can't it be just group_membership?
|
Thank you Ania! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Admin][Customer] Seeing detailed information about customer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.