[Admin][Product] Sort products within taxon

[tuka217]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	yes
Related tickets	-
License	MIT

[CoderMaggie]

This feature title and body do not describe well enough what we are checking here.

Feature: Adding a new product with a position within a taxon
In order to organize products within taxons in my shop
As an Administrator
I want to assign positions in taxons to products when I create them

I would suggest sth like that.

[CoderMaggie]

its position should be 0 in the "Soft Toys" taxon

[CoderMaggie]

I assign it to the "Soft Toys" taxon

[CoderMaggie]

Adding a new simple product with different positions in many taxons

[CoderMaggie]

this product is at position 1 in this taxon

[CoderMaggie]

A shipping method added without position is added as the last one

[michalmarcinkowski]

Travis was stalled, so I needed to trigger the hook once again.

[pjedrzejewski]

Thank you Ania, nice work! :)

[tchapi]

How do we find if a product has a taxon if we only know the slug of the taxon now ?

Suppose I have a filtered /products/{taxonSlug} route, and in my controller :

[...]
$taxon = $this->get('sylius.repository.taxon')->findOneBySlug($taxonSlug);

// Do I need to iterate over each productTaxon of each product ??
foreach ($products as $product) {
  foreach($product->getProductTaxons() as $productTaxon) {
    if ($productTaxon()->getTaxon() == $taxon) {
       // filter or do whatever
    }
  }
}

This seems a bit overkill, no ? Did I miss something ?

[michalmarcinkowski]

How about something like:
$this->get('sylius.repository.product')->findByTaxonSlug($taxonSlug);

return $this->createQueryBuilder('o')
            ->innerJoin('o.product_taxons', 'product_taxon')
            ->innerJoin('product_taxon.taxon', 'taxon')
            ->andWhere('product_taxon.taxon.slug = :slug')
            ->setParameter('slug', $taxonSlug)
            ->getQuery()
            ->getResult()
        ;

[michalmarcinkowski]

Anyway the previous implementation would look almost exactly the same as yours now:

foreach ($products as $product) {
  foreach($product->getTaxons() as $productTaxon) {
    if ($productTaxon == $taxon) {
       // filter or do whatever
    }
  }
}

[tchapi]

The for loop looks the same but doctrine hydrates thing differentely between the two, and performance can get tricky. I'll go with the Repository method I guess