Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github] Fix default PR description template #6633

Conversation

Zales0123
Copy link
Member

@Zales0123 Zales0123 commented Nov 4, 2016

There were problems with | signs in few rows.

Previous:
zrzut ekranu 2016-11-04 o 10 09 49

Now:
zrzut ekranu 2016-11-04 o 10 45 53

Copy link
Contributor

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not:

| Q               | A 
| --------------- | ---
| Bug fix?        | no\|yes
| New feature?    | no\|yes
| BC breaks?      | no\|yes
| Related tickets | fixes #X, partially #Y, mentioned in #Z
| License         | MIT
Q A
Bug fix? no
New feature? no
BC breaks? no
Related tickets fixes #X, partially #Y, mentioned in #Z
License MIT

@Zales0123 Zales0123 force-pushed the fix-default-pr-description-template branch from 18dc753 to 82bdc4e Compare November 4, 2016 09:46
@Zales0123
Copy link
Member Author

👍

@pamil
Copy link
Contributor

pamil commented Nov 4, 2016

We can remove | at the end of the lines now 🎉

@Zales0123 Zales0123 force-pushed the fix-default-pr-description-template branch from 82bdc4e to 2e096d2 Compare November 4, 2016 09:56
@Zales0123 Zales0123 closed this Nov 4, 2016
@Zales0123 Zales0123 reopened this Nov 4, 2016
@Zales0123
Copy link
Member Author

Ups 😄

| BC breaks? | no|yes
| Bug fix? | no\|yes
| New feature? | no\|yes
| BC breaks? | no\|yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about | BC breaks? | no/yes? 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zales0123 Please adjust the template and it is good to go!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done this way, as @pamil suggested previously, to keep this | signs rather than replace them into something else. So I don't know now, should it be | or / 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why? I want to choose "yes" or "no" and that's it, so using "/" is one less backspace.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but the point was not to change how PR table looks like, but only to fix it :) I have no problem with slash and could change it in a minute ;)
zrzut ekranu 2016-11-07 o 09 38 12

@pjedrzejewski pjedrzejewski added the Maintenance CI configurations, READMEs, releases, etc. label Nov 7, 2016
@Zales0123 Zales0123 force-pushed the fix-default-pr-description-template branch from 2e096d2 to f4c79dd Compare November 7, 2016 09:11
@michalmarcinkowski michalmarcinkowski merged commit 10b4584 into Sylius:master Nov 8, 2016
@michalmarcinkowski
Copy link
Contributor

👍

@Zales0123 Zales0123 deleted the fix-default-pr-description-template branch November 9, 2016 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants