-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Github] Fix default PR description template #6633
[Github] Fix default PR description template #6633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not:
| Q | A
| --------------- | ---
| Bug fix? | no\|yes
| New feature? | no\|yes
| BC breaks? | no\|yes
| Related tickets | fixes #X, partially #Y, mentioned in #Z
| License | MIT
Q | A |
---|---|
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Related tickets | fixes #X, partially #Y, mentioned in #Z |
License | MIT |
18dc753
to
82bdc4e
Compare
👍 |
We can remove |
82bdc4e
to
2e096d2
Compare
Ups 😄 |
| BC breaks? | no|yes | ||
| Bug fix? | no\|yes | ||
| New feature? | no\|yes | ||
| BC breaks? | no\|yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about | BC breaks? | no/yes
? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zales0123 Please adjust the template and it is good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done this way, as @pamil suggested previously, to keep this |
signs rather than replace them into something else. So I don't know now, should it be |
or /
😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why? I want to choose "yes" or "no" and that's it, so using "/" is one less backspace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2e096d2
to
f4c79dd
Compare
👍 |
There were problems with
|
signs in few rows.Previous:
Now: