[Taxon] Edit taxon slug #6657
Merged
[Taxon] Edit taxon slug #6657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjedrzejewski
added
BC Break
Zales0123
force-pushed
the
edit-taxons-slug
branch
from
8dab76d
to
e6e8fe8
Compare
Zales0123
force-pushed
the
edit-taxons-slug
branch
3 times, most recently
from
5d51246
to
699401c
Compare
Zales0123
force-pushed
the
edit-taxons-slug
branch
from
699401c
to
c35d9da
Compare
Zales0123
force-pushed
the
edit-taxons-slug
branch
from
c35d9da
to
78cfc2c
Compare
|
Thank you Mateusz! :) |
pamil
reviewed
Nov 9, 2016
| private function waitForSlugGenerationIfNecessary() | ||
| { | ||
| if ($this->getDriver() instanceof Selenium2Driver) { | ||
| $this->getDocument()->waitFor(1000, function () { |
There was a problem hiding this comment.
Waiting for 1000 seconds seems like quite too much.
| } | ||
|
|
||
| $value = $slugElement->getValue(); | ||
| $this->getDocument()->waitFor(1000, function () use ($slugElement, $value) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$permalinkand based on$slug