[Product][Shop] Buy product in correct prices for channel and currency #6666
Conversation
Zales0123
commented
Nov 8, 2016
•
Zales0123
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Related tickets | |
| License | MIT |
Zales0123
force-pushed
the
buy-product-in-correct-price-for-channel-and-currency
branch
from
3dd1812
to
cbd7fc0
Compare
Zales0123
changed the title
|
I've opened this PR accidentally (I didn't want to open it yet) - but then I've just realized I can't lose such a beautiful PR number as #6666 😄 |
Zales0123
force-pushed
the
buy-product-in-correct-price-for-channel-and-currency
branch
2 times, most recently
from
dab967c
to
203d11b
Compare
|
@pjedrzejewski @michalmarcinkowski do we want also to implement displaying product price based on pricing calculator on product's details page? Or is it the case for the separate PR? |
Zales0123
changed the title
Zales0123
force-pushed
the
buy-product-in-correct-price-for-channel-and-currency
branch
from
203d11b
to
55bf26b
Compare
There was a problem hiding this comment.
- The amounts in the configuration array will be stored in the specific currency, not base amount. You should take exchange rates into account in scenarios and in the calculator, convert the specified amount to the base amount before returning it.
- It should not use currency context - this makes it stateful. It should get the currency as part of the "context" array passed to the calculator.
Zales0123
force-pushed
the
buy-product-in-correct-price-for-channel-and-currency
branch
2 times, most recently
from
0061b0a
to
21bbb2c
Compare
| @@ -150,9 +150,6 @@ public function thatChannelAllowsToShopUsingAndCurrencies(ChannelInterface $chan | |||
| public function itUsesTheCurrencyByDefault(ChannelInterface $channel, $currencyCode) | |||
| { | |||
| $currency = $this->provideCurrency($currencyCode); | |||
| $currency->setExchangeRate(1.0); | |||
There was a problem hiding this comment.
Why removing this?
There was a problem hiding this comment.
This step is that channel uses the currency by default -> it should not set this currency's exchange rate to 1.0, as exchange rate is not configured per channel, but for whole system. In my case, it caused a mistake when one channel has base currency EUR and the other one GBP.
There was a problem hiding this comment.
Ok, so it means channel, not store. Totally valid fix, good catch! 👍
| */ | ||
| public function itHasDifferentPricesForDifferentChannelsAndCurrencies(ProductInterface $product) | ||
| { | ||
| $product->getFirstVariant()->setPricingCalculator(Calculators::CHANNEL_AND_CURRENCY_BASED); |
There was a problem hiding this comment.
getFirstVariant method should be removed. defaultVariantResolver should be used instead.
| ChannelInterface $channel, | ||
| $currency | ||
| ) { | ||
| $variant = $product->getFirstVariant(); |
| @@ -20,6 +20,7 @@ | |||
| <argument type="service" id="__symfony__.sylius.factory.channel" /> | |||
| <argument type="service" id="__symfony__.sylius.repository.channel" /> | |||
| <argument type="service" id="__symfony__.sylius.manager.channel" /> | |||
| <argument>%__behat__.mink.parameters%</argument> | |||
There was a problem hiding this comment.
Do we need this?
Zales0123
force-pushed
the
buy-product-in-correct-price-for-channel-and-currency
branch
2 times, most recently
from
238d561
to
8322b7a
Compare
Zales0123
force-pushed
the
buy-product-in-correct-price-for-channel-and-currency
branch
from
8322b7a
to
e9ba0f9
Compare
|
@pamil Not anymore 🐫 |
|
Thank you Mateusz! Please apply all comments in a separate PR. |
Zales0123
deleted the
buy-product-in-correct-price-for-channel-and-currency
branch
