Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Payum] Add Be2bill gateway #669

Merged
merged 7 commits into from
Dec 4, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/config/parameters.yml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ parameters:
stripe.secret_key: EDITME
stripe.test_mode: true

be2bill.identifier: EDITME
be2bill.password: EDITME
be2bill.sandbox: true

sylius.oauth.amazon.clientid: <amazon_client_id>
sylius.oauth.amazon.clientsecret: <amazon_client_secret>
sylius.oauth.facebook.clientid: <facebook_client_id>
Expand Down
21 changes: 21 additions & 0 deletions app/config/payum.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,27 @@ payum:
doctrine:
driver: orm

be2bill:
be2bill:
api:
options:
identifier: %be2bill.identifier%
password: %be2bill.password%
sandbox: %be2bill.sandbox%
actions:
- sylius.payum.be2bill.action.capture_order_using_credit_card
- sylius.payum.action.obtain_credit_card
- sylius.payum.action.order_status
- sylius.payum.action.execute_same_request_with_payment_details

storages:
Sylius\Bundle\CoreBundle\Model\Order:
doctrine:
driver: orm
Sylius\Bundle\PaymentsBundle\Model\Payment:
doctrine:
driver: orm

dummy:
custom:
actions:
Expand Down
1 change: 1 addition & 0 deletions app/config/sylius.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ sylius_payments:
gateways:
dummy: Test
stripe: Stripe
be2bill: Be2Bill

sylius_payum: ~

Expand Down
1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"payum/payum": "~0.6.3",
"payum/payum-bundle": "~0.6.2",
"payum/paypal-express-checkout-nvp": "0.6.*",
"payum/be2bill": "0.6.*",
"payum/omnipay-bridge": "0.6.*"
},
"require-dev": {
Expand Down
58 changes: 56 additions & 2 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ public function load(ObjectManager $manager)
$manager->persist($this->createPaymentMethod('Dummy', 'dummy'));
$manager->persist($this->createPaymentMethod('Paypal Express Checkout', 'paypal_express_checkout'));
$manager->persist($this->createPaymentMethod('Stripe', 'stripe'));
$manager->persist($this->createPaymentMethod('Be2bill', 'be2bill'));

$manager->flush();
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,116 @@
<?php

/*
* This file is part of the Sylius package.
*
* (c) Paweł Jędrzejewski
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Sylius\Bundle\PayumBundle\Payum\Be2bill\Action;

use Payum\Action\PaymentAwareAction;
use Payum\Exception\LogicException;
use Payum\Exception\RequestNotSupportedException;
use Payum\Request\SecuredCaptureRequest;
use Sylius\Bundle\CoreBundle\Model\OrderInterface;
use Sylius\Bundle\PayumBundle\Payum\Request\ObtainCreditCardRequest;
use Symfony\Component\HttpFoundation\Request;

/**
* @author Alexandre Bacco <alexandre.bacco@gmail.com>
*/
class CaptureOrderUsingCreditCardAction extends PaymentAwareAction
{
protected $httpRequest;

public function setRequest(Request $request = null)
{
$this->httpRequest = $request;
}

/**
* {@inheritdoc}
*/
public function execute($request)
{
/** @var $request SecuredCaptureRequest */
if (!$this->supports($request)) {
throw RequestNotSupportedException::createActionNotSupported($this, $request);
}

if (!$this->httpRequest) {
throw new LogicException('The action can be run only when http request is set.');
}

/** @var OrderInterface $order */
$order = $request->getModel();
$payment = $order->getPayment();

$details = $payment->getDetails();

if (empty($details)) {
$this->payment->execute($obtainCreditCardRequest = new ObtainCreditCardRequest($order));

$details['AMOUNT'] = $order->getTotal();
$details['CLIENTEMAIL'] = $order->getUser()->getEmail();
$details['CLIENTUSERAGENT'] = $this->httpRequest->headers->get('User-Agent', 'Unknown');
$details['CLIENTIP'] = $this->httpRequest->getClientIp();
$details['CLIENTIDENT'] = $order->getUser()->getId();
$details['DESCRIPTION'] = sprintf('Order containing %d items for a total of %01.2f', $order->getItems()->count(), $order->getTotal() / 100);
$details['ORDERID'] = $order->getId();
$details['CARDCODE'] = $obtainCreditCardRequest->getCreditCard()->getNumber();
$details['CARDCVV'] = $obtainCreditCardRequest->getCreditCard()->getSecurityCode();
$details['CARDFULLNAME'] = $obtainCreditCardRequest->getCreditCard()->getCardholderName();
$details['CARDVALIDITYDATE'] = sprintf(
'%02d-%02d', $obtainCreditCardRequest->getCreditCard()->getExpiryMonth(), substr($obtainCreditCardRequest->getCreditCard()->getExpiryYear(), -2)
);

$payment->setDetails($details);
}

try {
$request->setModel($payment);
$this->payment->execute($request);

$request->setModel($order);

//TODO: when sensitive value object is used this would be removed. Require update to payum 0.7.
$details = $this->sanitizePayment($payment->getDetails());
$payment->setDetails($details);
} catch (\Exception $e) {
//TODO: when sensitive value object is used this would be removed. Require update to payum 0.7.
$details = $this->sanitizePayment($payment->getDetails());
$payment->setDetails($details);

throw $e;
}
}

/**
* {@inheritdoc}
*/
public function supports($request)
{
return
$request instanceof SecuredCaptureRequest &&
$request->getModel() instanceof OrderInterface
;
}

/**
* Sanitize paymentDetails array by removing all card-related data
* @param array $details
* @return array $details
*/
protected function sanitizePayment(array $details)
{
foreach (array('CARDCODE', 'CARDCVV', 'CARDFULLNAME', 'CARDVALIDITYDATE') as $idx) {
unset($details[$idx]);
}

return $details;
}
}
6 changes: 6 additions & 0 deletions src/Sylius/Bundle/PayumBundle/Resources/config/services.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
<parameter key="sylius.payum.checkout_step.purchase.class">Sylius\Bundle\PayumBundle\Checkout\Step\PurchaseStep</parameter>
<parameter key="sylius.payum.paypal.action.capture_order_using_express_checkout.class">Sylius\Bundle\PayumBundle\Payum\Paypal\Action\CaptureOrderUsingExpressCheckoutAction</parameter>
<parameter key="sylius.payum.stripe.action.capture_order_using_credit_card.class">Sylius\Bundle\PayumBundle\Payum\Stripe\Action\CaptureOrderUsingCreditCardAction</parameter>
<parameter key="sylius.payum.be2bill.action.capture_order_using_credit_card.class">Sylius\Bundle\PayumBundle\Payum\Be2bill\Action\CaptureOrderUsingCreditCardAction</parameter>
<parameter key="sylius.payum.dummy.action.capture_order.class">Sylius\Bundle\PayumBundle\Payum\Dummy\Action\CaptureOrderAction</parameter>
<parameter key="sylius.payum.dummy.action.order_status.class">Sylius\Bundle\PayumBundle\Payum\Dummy\Action\OrderStatusAction</parameter>
<parameter key="sylius.payum.action.order_status.class">Sylius\Bundle\PayumBundle\Payum\Action\OrderStatusAction</parameter>
Expand All @@ -36,6 +37,11 @@
</service>
<service id="sylius.payum.paypal.action.capture_order_using_express_checkout" class="%sylius.payum.paypal.action.capture_order_using_express_checkout.class%" />
<service id="sylius.payum.stripe.action.capture_order_using_credit_card" class="%sylius.payum.stripe.action.capture_order_using_credit_card.class%" />
<service id="sylius.payum.be2bill.action.capture_order_using_credit_card" class="%sylius.payum.be2bill.action.capture_order_using_credit_card.class%">
<call method="setRequest">
<argument type="service" id="request" on-invalid="null" strict="false" />
</call>
</service>
<service id="sylius.payum.action.order_status" class="%sylius.payum.action.order_status.class%" />
<service id="sylius.payum.action.execute_same_request_with_payment_details" class="%sylius.payum.action.execute_same_request_with_payment_details.class%" />
<service id="sylius.payum.action.obtain_credit_card" class="%sylius.payum.action.obtain_credit_card.class%" >
Expand Down