Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Use dbname from doctrine connection to allow custom values #6692

Merged
merged 1 commit into from
Nov 14, 2016
Merged

[Core] Use dbname from doctrine connection to allow custom values #6692

merged 1 commit into from
Nov 14, 2016

Conversation

vntw
Copy link
Contributor

@vntw vntw commented Nov 10, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no

This change makes it possible to use the same database name in every environment. Currently, the InstallDatabaseCommand will always prepend _%env% to the database name, even if I specified sylius (no _%env%) in my dev config, which won't match the expectations made here.

It will return NULL for SQLite and eventually explode since listDatabases is not supported anyway.

@pjedrzejewski pjedrzejewski merged commit 3d265c5 into Sylius:master Nov 14, 2016
@pjedrzejewski
Copy link
Member

Thank you @venyii! 👍

@vntw vntw deleted the use-connection-dbname branch November 15, 2016 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants