[Core] Ensure writable web/ directories with absolute paths in the installer #6697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following `askConfirmation` call will automatically return the default value (`false`) if it's in non-interactive mode.
To give the user some feedback what exactly happened, especially in non-interactive mode since this command will never run (currently).
lchrusciel
approved these changes
Nov 11, 2016
|
Thank you @venyii! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem when the install command is not called from the Symfony root directory. Since the web paths are relative, the directories will be created wherever I call the installer from.
Additionally, I removed a
no-interactioncheck since Symfony'saskConfirmationmethod will do this automatically for us in the next step.