Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Behat] Fix wait for methods #6710

Merged
merged 1 commit into from
Nov 14, 2016
Merged

[Behat] Fix wait for methods #6710

merged 1 commit into from
Nov 14, 2016

Conversation

Arminek
Copy link
Contributor

@Arminek Arminek commented Nov 14, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
License MIT

pamil
pamil approved these changes Nov 14, 2016
View reviewed changes
src/Sylius/Behat/Page/Admin/Taxon/CreatePage.php
@@ -73,8 +73,8 @@ public function deleteTaxonOnPageByName($name)
$deleteButton = $leaf->find('css', '.sylius-delete-resource');
$deleteButton->click();

$deleteButton->waitFor(5, function () {
return false;
Copy link
Contributor

@pamil pamil Nov 14, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XD

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zrzut ekranu 2016-11-14 o 11 27 12

@pjedrzejewski pjedrzejewski merged commit 9b62063 into Sylius:master Nov 14, 2016
@pjedrzejewski
Copy link
Member

Thanks Arek! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 left review comments

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Arminek @pjedrzejewski @pamil @Zales0123