[Cart][Inventory] Fix cart inventory validation #6712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arminek
commented
Nov 14, 2016
Arminek
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Related tickets | Sylius/Sylius-Standard#135 |
| License | MIT |
Arminek
changed the title
Arminek
changed the title
pamil
suggested changes
Nov 14, 2016
| @@ -293,7 +293,7 @@ public function iAddQuantityOfProductsToTheCart($quantity, ProductInterface $pro | |||
|
|
|||
| /** | |||
| * @Given /^I have(?:| added) (\d+) (products "([^"]+)") (?:to|in) the cart$/ | |||
| * @When /^I add(?:|ed) (\d+) (products "([^"]+)") to the cart$/ | |||
| * @When /^I(?:| again) add(?:|ed) (\d+) (products "([^"]+)") to the cart$/ | |||
There was a problem hiding this comment.
This syntax just does not look right :<
| public function __construct(AvailabilityCheckerInterface $availabilityChecker, CartContextInterface $cartContext) | ||
| { | ||
| $this->availabilityChecker = $availabilityChecker; | ||
| $this->cartContext = $cartContext; |
There was a problem hiding this comment.
Just use $orderItem->getOrder().
There was a problem hiding this comment.
In this case Order has not been assigned yet.
Arminek
force-pushed
the
fix-cart-validaiton
branch
8 times, most recently
from
9c7b884
to
cda19fe
Compare
pjedrzejewski
requested changes
Nov 18, 2016
| @@ -165,5 +165,11 @@ | |||
| <argument type="service" id="form.registry" /> | |||
| <tag name="form.type" alias="sylius_product_variant" /> | |||
| </service> | |||
|
|
|||
| <service id="sylius.form.type.add_cart_item" class="Sylius\Bundle\CoreBundle\Form\Type\Order\AddCartItemType"> | |||
There was a problem hiding this comment.
Let's move this to OrderBundle.
| @@ -45,7 +45,7 @@ sylius_shop_cart_item_add: | |||
| method: createForProduct | |||
| arguments: [expr:service('sylius.repository.product').find($productId)] | |||
| form: | |||
| type: sylius_cart_item | |||
| type: sylius_add_cart_item | |||
|
Does it also fix #6635? |
Arminek
force-pushed
the
fix-cart-validaiton
branch
from
dfc3fdb
to
eaeca17
Compare
| @@ -13,6 +13,8 @@ sylius: | |||
| customer: | |||
| currency_code: | |||
| not_valid: The currency code you entered is invalid. | |||
| cart_item: | |||
| not_available: 'name does not have sufficient stock.' | |||
There was a problem hiding this comment.
That message seems wrong 😄
Arminek
force-pushed
the
fix-cart-validaiton
branch
2 times, most recently
from
c431107
to
c5e547a
Compare
Arminek
force-pushed
the
fix-cart-validaiton
branch
from
c5e547a
to
bb2a871
Compare
michalmarcinkowski
approved these changes
Nov 21, 2016
|
Great job Arek! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.