Adopted template overriding from other actions like update #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when you use the `SyliusResourceBundle` standalone, when you want to override the template for the delete action you have to define it this way:
``` yaml
my_delete:
pattern: /my/{id}
methods: [DELETE]
defaults:
_controller: my.controller.my:deleteAction
template: MyCoreBundle:My:delete.html.twig
```
This is inconsistent with the other actions. This PR changes this so that it works with the folloging syntax:
``` yaml
my_delete:
pattern: /my/{id}
methods: [DELETE]
defaults:
_controller: my.controller.my:deleteAction
_sylius:
template: MyCoreBundle:My:delete.html.twig
```
Before merging this PR we should reconfigure the routes so that `SyliusWebBundle:Backend/Misc:delete.html.twig` will be used again ;-)
|
👍 |
|
I can adjust the routes if you want, I just wanted to wait for feedback ;-) |
|
@snc Yes, please! Obviously I'm in favor of this change. thank you. :) |
|
Done, travis is working hard to test this PR now ;-) |
|
Looks good, there are some |
stloyd
added a commit
that referenced
this pull request
Jan 10, 2014
Adopted template overriding from other actions like update
|
Merged. Thanks Henrik! |
mtotheikle
pushed a commit
to Limelyte/Sylius
that referenced
this pull request
Jan 22, 2014
Merge pull request Sylius#675 from snc/patch-1 Adopted template overriding from other actions like update
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
Adopted template overriding from other actions like update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you use the
SyliusResourceBundlestandalone, when you want to override the template for the delete action you have to define it this way:This is inconsistent with the other actions. This PR changes this so that it works with the folloging syntax:
Before merging this PR we should reconfigure the routes so that
SyliusWebBundle:Backend/Misc:delete.html.twigwill be used again ;-)