Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Order][Cart] Clean up cart events #6754

Merged
merged 1 commit into from
Nov 17, 2016
Merged

[Order][Cart] Clean up cart events #6754

merged 1 commit into from
Nov 17, 2016

Conversation

Arminek
Copy link
Contributor

@Arminek Arminek commented Nov 17, 2016 •
edited
Loading

Q A
Bug fix? no
New feature? no
BC breaks? yes
Related tickets partially #3535
License MIT

@pjedrzejewski pjedrzejewski added the BC Break PRs introducing BC breaks (do not even try to merge). label Nov 17, 2016
@pjedrzejewski pjedrzejewski merged commit cac362a into Sylius:master Nov 17, 2016
@pjedrzejewski
Copy link
Member

Thanks Arek!

@teohhanhui
Copy link
Contributor

I don't understand why this change. It's very weird that sylius.order_item.pre_create is not called as would be expected.

@Arminek
Copy link
Contributor Author

Arminek commented Dec 4, 2018

@teohhanhui You might be right. If I remeber corectly this part of OrderController is only used in cart context that is why we decided to name it like that to give it more context. Could some one confirm? /cc @lchrusciel @Zales0123 @GSadee

pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
@pjedrzejewski
Merge pull request Sylius#6754 from Arminek/clean-up-cart-events
1c2bad1 
[Order][Cart] Clean up cart events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
BC Break PRs introducing BC breaks (do not even try to merge).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Arminek @pjedrzejewski @teohhanhui @GSadee @Zales0123 @lchrusciel