Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin][Shop][Ui] Js clean up #6807

Merged
merged 7 commits into from
Nov 23, 2016
Merged

Conversation

Arminek
Copy link
Contributor

@Arminek Arminek commented Nov 22, 2016

Q A
Bug fix? no
New feature? no
BC breaks? no
License MIT

Javascript clean up and dx improvements.

  • Creating app in Admin, Shop, Ui for initialization of any custom plugins
  • Moving & Making generic plugins
  • Moving all ajax like routing to proper namespace & and use route names instead of hardcoded uri (FosJsRoutingBundle? to expose those routes)

@pjedrzejewski pjedrzejewski added the UX Issues and PRs aimed at improving User eXperience. label Nov 22, 2016
@Arminek Arminek changed the title [Wip][Admin][Shop][Ui] Js clean up [Admin][Shop][Ui] Js clean up Nov 23, 2016
@pjedrzejewski pjedrzejewski merged commit cb58dd1 into Sylius:master Nov 23, 2016
@pjedrzejewski
Copy link
Member

Great work Arek, thank you! :)

pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants