Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecations from custom validators #6815

Merged
merged 1 commit into from
Nov 22, 2016
Merged

Remove deprecations from custom validators #6815

merged 1 commit into from
Nov 22, 2016

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Nov 22, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets extracted from #6738
License MIT

pamil
pamil commented Nov 22, 2016
View reviewed changes
src/Sylius/Bundle/CoreBundle/spec/Validator/Constraints/ImageUniqueCodeValidatorSpec.php
* file that was distributed with this source code.
*/

namespace spec\Sylius\Bundle\CoreBundle\Validator\Constraint;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not even run by PhpSpec because the namespace is missing "s" at the end.

@pjedrzejewski pjedrzejewski merged commit 76efd44 into Sylius:master Nov 22, 2016
@pjedrzejewski
Copy link
Member

Thanks Kamil!

@pamil pamil deleted the symfony3-validators branch November 22, 2016 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@michalmarcinkowski michalmarcinkowski michalmarcinkowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pamil @pjedrzejewski @lchrusciel @michalmarcinkowski