Finalize shop UI, routing and templates #6843
Conversation
pjedrzejewski
commented
Nov 24, 2016
pjedrzejewski
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | yes |
| Related tickets | - |
| License | MIT |
- Also changes the payment method change flow and routing.
- Removed "sylius_get_cart()" helper from Twig, which was just plain wrong.
- WIP
pjedrzejewski
added
BC Break
pjedrzejewski
force-pushed
the
ui/finalize-shop
branch
from
8b96542
to
bb0bfe2
Compare
| @@ -75,6 +77,8 @@ gulp.task('shop-css', function() { | |||
| }); | |||
|
|
|||
| gulp.task('shop-img', function() { | |||
| gulp.src(['../../../../node_modules/lightbox2/dist/images/*']).pipe(gulp.dest(shopRootPath + 'images/')); | |||
There was a problem hiding this comment.
You should move this to img: [node_modules + '/lightbox2/dist/images/*'].
pjedrzejewski
force-pushed
the
ui/finalize-shop
branch
7 times, most recently
from
ec4f871
to
85aa289
Compare
| @@ -31,7 +31,7 @@ Feature: Preventing shipping step completion without a selected method | |||
| Then I should not be able to complete the shipping step | |||
| And there should be information about no shipping methods available for my shipping address | |||
|
|
|||
| @ui | |||
| @ui @todo | |||
There was a problem hiding this comment.
Why these are @todo?
There was a problem hiding this comment.
Darn, this was a bit hard to redo in templates unless you get a crappy structure. Anyway, the issue was that logic was in the templates and not in PHP... We will bring that back later or I may figure out something fast.
There was a problem hiding this comment.
But it looks like already fixed https://github.com/Sylius/Sylius/pull/6843/files/85aa2899973df5748324da547e568e247ce0a630#diff-81e9307596c4fe5ab65cbb5649572290R1.
There was a problem hiding this comment.
Ok, it doesn't handle the case when no methods are available.
pjedrzejewski
force-pushed
the
ui/finalize-shop
branch
from
85aa289
to
83e7c7b
Compare
pjedrzejewski
changed the title
|
Awesome job! Thanks Paweł 👍 |
