[Currency] Exchange rate refactor #6846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalmarcinkowski
added
BC Break
lchrusciel
changed the title
| } | ||
|
|
||
| return (int) round($amount * $currency->getExchangeRate()); | ||
| return (int) round($amount * $exchangeRate->getRatio()); |
There was a problem hiding this comment.
We have two cases here:
- Ratio for
source->target(multiply) - Ratio for
target->source(divide)
if ($exchangeRate->getSourceCurrency()->getCode() === $sourceCurrencyCode) {
return (int) round(amount * $exchangeRate->getRatio());
}
return (int) round(amount / $exchangeRate->getRatio());
This should be covered by Behat.
| { | ||
| if (isset($this->cache[$code])) { | ||
| return $this->cache[$code]; | ||
| $cacheIndex = $sourceCode . $targetCode; |
There was a problem hiding this comment.
$cacheIndex = sprintf('%s-%s', $sourceCode, $targetCode);
lchrusciel
force-pushed
the
exchange-rate-refactor
branch
from
173a7b1
to
306793c
Compare
lchrusciel
changed the title
lchrusciel
changed the title
lchrusciel
force-pushed
the
exchange-rate-refactor
branch
6 times, most recently
from
6c893c8
to
215f832
Compare
lchrusciel
changed the title
lchrusciel
force-pushed
the
exchange-rate-refactor
branch
from
215f832
to
ec56d60
Compare
lchrusciel
force-pushed
the
exchange-rate-refactor
branch
from
ec56d60
to
bc3f754
Compare
|
Well done! Getting closer to party 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #6820