Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improved order details page (backend) #687

Merged
merged 7 commits into from
Dec 10, 2013

Conversation

kayue
Copy link
Contributor

@kayue kayue commented Dec 5, 2013

Please give me some quick feedback :)

Beside the obvious visual changes, I also added a payment table at the bottom. This could be useful right?

Old

old

New

new

@stloyd
Copy link
Contributor

stloyd commented Dec 5, 2013

@kayue Nice! I but I'm not sure that showing images is good idea TBH =)

@arnolanglade
Copy link
Contributor

@kayue 👍

@jjanvier
Copy link
Contributor

jjanvier commented Dec 5, 2013

I like it. But why did you remove the "Manage orders" button and all the details (total, item total, tax total, shipping total) ? It gives a quick overview of the order without having to scroll, don't you think ?

@stloyd
Copy link
Contributor

stloyd commented Dec 5, 2013

@jjanvier They are not removed (oh, ok, only that button =)) but I can agree that the order item list should be at the end, IMO it's more important to see details like payment/shipping etc. than contant of order =)

@kayue
Copy link
Contributor Author

kayue commented Dec 5, 2013

@stloyd The picture is a very useful piece of information for store operator to identify the product. I run a store with over 18,000 cloths naming like this:

  • M.V.P. X NEIGHBORHOOD BLACK NHMV.2 “C-TEE.SS.” T-SHIRT
  • M.V.P. X NEIGHBORHOOD WHITE NHMV.2 “C-TEE.SS.” T-SHIRT
  • M.V.P. X NEIGHBORHOOD NAVY NHMV.WOOL SHIRT

In our case the name doesn't mean much for our operators.

@jjanvier I removed them purely because they are duplicated. Basically I want the order page look similar to a printed invoice.

I have a question: is one order can only have one payment and one shipment? Multiple shipment is not possible at the moment right? If yes I think I can put payment and shipment status to the top easily. Maybe just use two labels.

@kayue
Copy link
Contributor Author

kayue commented Dec 6, 2013

@stloyd @jjanvier What do you think about the design below?

screen shot 2013-12-07 at 12 13 02 am

@kayue
Copy link
Contributor Author

kayue commented Dec 10, 2013

Any thoughts?

@stloyd
Copy link
Contributor

stloyd commented Dec 10, 2013

@kayue I like it, I would just put the labels in Payment/Shipment with pull-right and different colors (this one right now is to bright IMO)

@aniltc
Copy link

aniltc commented Dec 10, 2013

can we download this changes ?

@aniltc
Copy link

aniltc commented Dec 10, 2013

It seems you have directly done these changes in sylius.Is it possible to override this page and make the necessary changes in a seprate bundle for my application ?

@stloyd
Copy link
Contributor

stloyd commented Dec 10, 2013

@aniltc Please read the docs of Symfony to learn how to do this: http://symfony.com/doc/2.3/cookbook/bundles/inheritance.html, your question has nothing to do with this enhancement.

@aniltc
Copy link

aniltc commented Dec 10, 2013

Thanks.I am aware of overrding concepts.Here the code chnaged in sylius itself.I would like to know sylius approved thos code and can I use this code ?

@stloyd
Copy link
Contributor

stloyd commented Dec 10, 2013

@aniltc Sylius is released with MIT license, so any contributions that are merged into core are being released with same license, so till you hold the original license headers and copyrights in used files (you can edit them of course, by original author details & license/copyrights must be hold), till you can use them within your code.

@kayue
Copy link
Contributor Author

kayue commented Dec 10, 2013

@stloyd Updated the design.

screen shot 2013-12-10 at 5 43 41 pm

@aniltc You don't need approval if you don't want to contribute your changes to the Sylius core. In my company's project we do extend the WebBundle, and we only contribute part of our changes back to Sylius's core (for example this one).

@stloyd
Copy link
Contributor

stloyd commented Dec 10, 2013

@kayue Looks good for me!
@pjedrzejewski @jjanvier Anything missing here?

@jjanvier
Copy link
Contributor

great for me too 👍

pjedrzejewski pushed a commit that referenced this pull request Dec 10, 2013
[WIP] Improved order details page (backend)
@pjedrzejewski pjedrzejewski merged commit ae130ab into Sylius:master Dec 10, 2013
@pjedrzejewski
Copy link
Member

Looks very nice, thank you a lot @kayue. @stloyd wsup with this phpspec error on 5.3? Do you know anything?

@kayue kayue deleted the ui/improved-order-page branch December 10, 2013 12:02
@Richtermeister
Copy link
Contributor

Pretty! Thanks @kayue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants