-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Improved order details page (backend) #687
Conversation
Nicer billing address / shipping address format.
Conflicts: src/Sylius/Bundle/WebBundle/Resources/assets/css/backend.css
@kayue Nice! I but I'm not sure that showing images is good idea TBH =) |
@kayue 👍 |
I like it. But why did you remove the "Manage orders" button and all the details (total, item total, tax total, shipping total) ? It gives a quick overview of the order without having to scroll, don't you think ? |
@jjanvier They are not removed (oh, ok, only that button =)) but I can agree that the order item list should be at the end, IMO it's more important to see details like payment/shipping etc. than contant of order =) |
@stloyd The picture is a very useful piece of information for store operator to identify the product. I run a store with over 18,000 cloths naming like this:
In our case the name doesn't mean much for our operators. @jjanvier I removed them purely because they are duplicated. Basically I want the order page look similar to a printed invoice. I have a question: is one order can only have one payment and one shipment? Multiple shipment is not possible at the moment right? If yes I think I can put payment and shipment status to the top easily. Maybe just use two labels. |
Any thoughts? |
@kayue I like it, I would just put the labels in Payment/Shipment with |
can we download this changes ? |
It seems you have directly done these changes in sylius.Is it possible to override this page and make the necessary changes in a seprate bundle for my application ? |
@aniltc Please read the docs of Symfony to learn how to do this: http://symfony.com/doc/2.3/cookbook/bundles/inheritance.html, your question has nothing to do with this enhancement. |
Thanks.I am aware of overrding concepts.Here the code chnaged in sylius itself.I would like to know sylius approved thos code and can I use this code ? |
@aniltc Sylius is released with MIT license, so any contributions that are merged into core are being released with same license, so till you hold the original license headers and copyrights in used files (you can edit them of course, by original author details & license/copyrights must be hold), till you can use them within your code. |
@kayue Looks good for me! |
great for me too 👍 |
[WIP] Improved order details page (backend)
Pretty! Thanks @kayue |
Please give me some quick feedback :)
Beside the obvious visual changes, I also added a payment table at the bottom. This could be useful right?
Old
New