Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC][BC Break] Rename checkout summary event #6875

Merged
merged 1 commit into from
Nov 26, 2016
Merged

[RFC][BC Break] Rename checkout summary event #6875

merged 1 commit into from
Nov 26, 2016

Conversation

michalmarcinkowski
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? yes
Related tickets
License MIT

IMO complete is more appropriate name for an event dispatched after the checkout summary step.

@michalmarcinkowski michalmarcinkowski added BC Break PRs introducing BC breaks (do not even try to merge). RFC Discussions about potential changes or new features. labels Nov 26, 2016
@pjedrzejewski pjedrzejewski merged commit 4321ff6 into Sylius:master Nov 26, 2016
@pjedrzejewski
Copy link
Member

Definitely, all events are matching the transition name. Thanks Michał!

@michalmarcinkowski michalmarcinkowski deleted the rename-checkout-event branch December 3, 2016 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC Break PRs introducing BC breaks (do not even try to merge). RFC Discussions about potential changes or new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michalmarcinkowski @pjedrzejewski