Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loggable #6890

Merged
merged 1 commit into from
Nov 28, 2016
Merged

Remove loggable #6890

merged 1 commit into from
Nov 28, 2016

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Nov 28, 2016

Q A
Bug fix? no
New feature? no
BC breaks? no
Related tickets
License MIT

@michalmarcinkowski michalmarcinkowski added the BC Break PRs introducing BC breaks (do not even try to merge). label Nov 28, 2016
@Shine-neko
Copy link
Contributor

Why ?

@pjedrzejewski
Copy link
Member

@Shine-neko Because we do not support this feature properly, you can easily add the same thing to your app. We will reimplement this for BETA2 release.

@mickaelandrieu
Copy link
Contributor

@pjedrzejewski is it worth to make a BC break between beta 1 and beta 2, because it's not perfect ?

@pjedrzejewski
Copy link
Member

@mickaelandrieu Introducing it back won't cause any major BC break. We do not display these in the admin anywhere.

@michalmarcinkowski
Copy link
Contributor

@mickaelandrieu it's better to put a tag on features that are fully working and add new features later when they will be implemented well and working without any issues. This feature is not well thought out, so if we leave it as it is now we will have to do BC breaks after beta anyway to fix it. If you use it now, you can easily add it back in your application.

@pjedrzejewski pjedrzejewski merged commit 25e601c into Sylius:master Nov 28, 2016
@pjedrzejewski
Copy link
Member

Thank you Grzesiu!

@GSadee GSadee deleted the remove-loggable branch September 22, 2017 08:32
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break PRs introducing BC breaks (do not even try to merge).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants