-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove loggable #6890
Remove loggable #6890
Conversation
GSadee
commented
Nov 28, 2016
Q | A |
---|---|
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Related tickets | |
License | MIT |
c5502d9
to
b70fc51
Compare
b70fc51
to
34c9d96
Compare
Why ? |
@Shine-neko Because we do not support this feature properly, you can easily add the same thing to your app. We will reimplement this for BETA2 release. |
@pjedrzejewski is it worth to make a BC break between beta 1 and beta 2, because it's not perfect ? |
@mickaelandrieu Introducing it back won't cause any major BC break. We do not display these in the admin anywhere. |
@mickaelandrieu it's better to put a tag on features that are fully working and add new features later when they will be implemented well and working without any issues. This feature is not well thought out, so if we leave it as it is now we will have to do BC breaks after beta anyway to fix it. If you use it now, you can easily add it back in your application. |
Thank you Grzesiu! |