Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Currency] [Critical] Channel based currencies support #6901

Merged
merged 66 commits into from
Nov 28, 2016

Conversation

lchrusciel
Copy link
Member

@lchrusciel lchrusciel commented Nov 28, 2016

Q A
Bug fix? yes
New feature? yes
BC breaks? yes
Related tickets fixes #6641
License MIT

Rebased and fixed version of #6868

Contains also #6896

@lchrusciel lchrusciel changed the title [Currency] [RFC] [Critical] Channel based currencies support [Currency] [Critical] Channel based currencies support Nov 28, 2016
@michalmarcinkowski michalmarcinkowski added BC Break PRs introducing BC breaks (do not even try to merge). Bug Fix Critical Issues and PRs, which are critical and should be fixed ASAP. labels Nov 28, 2016
@@ -14,7 +14,7 @@
<container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
<services>
<service id="sylius.form.type.security_login" class="Sylius\Bundle\UiBundle\Form\Type\SecurityLoginType">
<tag name="form.type" />
<tag name="form.type" alias="sylius_security_login" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurr durr 🌮

@lchrusciel lchrusciel force-pushed the rebased-currency-party branch 6 times, most recently from 15cb723 to 566b158 Compare November 28, 2016 17:37
@michalmarcinkowski michalmarcinkowski merged commit b5ed7ca into Sylius:master Nov 28, 2016
@michalmarcinkowski
Copy link
Contributor

Awesome job guys! 👍 👍 👍 🎉

@lchrusciel
Copy link
Member Author

It is not over yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break PRs introducing BC breaks (do not even try to merge). Critical Issues and PRs, which are critical and should be fixed ASAP.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rounding Issues in Cart
7 participants