fix for incorrect query building in Repositories.

[molchanoviv]

fix for incorrect query building in Repositories If $value is array.

[stloyd]

I would replace it with Doctrine Expr class calls:

if (!is_array($value)) {
    $queryBuilder->andWhere($queryBuilder->expr()->eq($this->getPropertyName($property), $property));
} else {
    $queryBuilder->andWhere($queryBuilder->expr()->in($this->getPropertyName($property), array($property)));
}

[molchanoviv]

Great idea. I forgot about Expr. Thanks

[molchanoviv]

@Arn0d I agree. What about adding constants with operators from the WHERE clause to Sylius\Bundle\ResourceBundle\Doctrine\ORM\EntityRepository and use this constants as unnecessary paramter in findBy and findOneBy functions?

ping @pjedrzejewski @stloyd

[molchanoviv]

@Arn0d When I started to implement this i realized that the idea with constants is not the best. Because in the case when $value is array we can want to create complicated query like ... WHERE table.field1 <> :param1 AND (table.field2 = :param2 OR table.field2 = :param3) ... Thats why i think creating this queries manually by query builder or writing your own DQL query still is the best solution.

[molchanoviv]

@pjedrzejewski Please merge. We are going to QA tonight. Thats why i need this fixed.

[stloyd]

@molchanoviv This can't be merge till Travis-CI will pass, now it dies with Doctrine exception, please fix it and then we can merge.

[arnolanglade]

@molchanoviv : ok !

[stloyd]

This is not correct, it must be array(':'.$property) otherwise Doctrine will fail.

[pjedrzejewski]

Thanks Ivan!

[stloyd]

This broke the spec: spec\Sylius\Bundle\ResourceBundle\Doctrine\ORM\EntityRepositorySpec.