Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade packages to Symfony 3 #6910

Merged
merged 3 commits into from
Nov 28, 2016
Merged

Upgrade packages to Symfony 3 #6910

merged 3 commits into from
Nov 28, 2016

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Nov 28, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Related tickets related to #6738 and #6896
License MIT

@pjedrzejewski pjedrzejewski added BC Break PRs introducing BC breaks (do not even try to merge). Symfony 3.0 labels Nov 28, 2016
@pamil pamil mentioned this pull request Nov 28, 2016
Merged
@pjedrzejewski pjedrzejewski merged commit f9b274f into Sylius:master Nov 28, 2016
@pjedrzejewski
Copy link
Member

Thanks Kamil!

@pamil pamil deleted the symfony3-wololo-packages branch November 28, 2016 23:02
@bendavies
Copy link
Contributor

amazing effort @pamil

@bigfoot90 bigfoot90 mentioned this pull request Nov 29, 2016
Closed
@bendavies
Copy link
Contributor

@pamil symfony 3.2 is tagged

@pjedrzejewski
Copy link
Member

See #6948. :)

@bendavies
Copy link
Contributor

@pamil so are non core bundles (settings bundle) remaining on symfony 2.8? abandoned?
What did you replace settings bundle functionality with in sylius?

@michalmarcinkowski
Copy link
Contributor

We didn't use settings in core and this bundle is a generic Symfony bundle not even related to eCommerce, so we excluded it from main repository. We're still trying to figure out the best approach to these not eCommerce bundles and extensions, so stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC Break PRs introducing BC breaks (do not even try to merge).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pamil @pjedrzejewski @bendavies @michalmarcinkowski