[Admin][Product] Hide generating variants for product without options #6924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Nov 29, 2016
GSadee
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Related tickets | |
| License | MIT |
| route: sylius_admin_product_variant_generate | ||
| parameters: | ||
| productId: $productId | ||
| product: expr:service('sylius.repository.product').findOneById($productId) |
GSadee
force-pushed
the
hide-generate-variants
branch
from
194ea4d
to
73b7a31
Compare
michalmarcinkowski
approved these changes
Nov 29, 2016
GSadee
force-pushed
the
hide-generate-variants
branch
2 times, most recently
from
0c6d79c
to
b6e7214
Compare
GSadee
force-pushed
the
hide-generate-variants
branch
from
b6e7214
to
a9c1048
Compare
michalmarcinkowski
approved these changes
Nov 29, 2016
There was a problem hiding this comment.
@pjedrzejewski packages are wrongly cached, please force merge.
|
Thanks Grzesiu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.