Models clean up #6934
Merged
Models clean up #6934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Nov 29, 2016
GSadee
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Related tickets | |
| License | MIT |
michalmarcinkowski
added
the
BC Break
| /** | ||
| * @return string | ||
| */ | ||
| public function getInventoryName(); |
There was a problem hiding this comment.
This method should be removed 💥
| use Sylius\Component\Order\Model\OrderItemUnitInterface as BaseOrderItemUnitInterface; | ||
| use Sylius\Component\Shipping\Model\ShipmentUnitInterface; | ||
|
|
||
| /** | ||
| * @author Mateusz Zalewski <mateusz.zalewski@lakion.com> | ||
| */ | ||
| interface OrderItemUnitInterface extends BaseOrderItemUnitInterface, InventoryUnitInterface, ShipmentUnitInterface | ||
| interface OrderItemUnitInterface extends BaseOrderItemUnitInterface, ShipmentUnitInterface |
There was a problem hiding this comment.
Why removing InventoryUnitInterface? The concept of Inventory unit should stay.
There was a problem hiding this comment.
I removed that because of one method, which I wanted to add to InventoryUnitInterface. I revert this removal 👍
GSadee
force-pushed
the
interfaces-clean-up
branch
from
8162ad0
to
2be3769
Compare
GSadee
force-pushed
the
interfaces-clean-up
branch
from
2be3769
to
77c63ca
Compare
|
Thanks Grzesiu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.