Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make forms & related stuff final again #6943

Merged
merged 1 commit into from
Nov 30, 2016

Conversation

michalmarcinkowski
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? yes
Related tickets -
License MIT

If you need to extend a form type - create a form type extension.
If you need to create a new form type on top of an existing one - create it and define getParent().

And data transformers / event listeners shouldn't be extended anyway.

Rebased #6925.

@michalmarcinkowski michalmarcinkowski added BC Break PRs introducing BC breaks (do not even try to merge). Bug Fix labels Nov 30, 2016
@pjedrzejewski pjedrzejewski merged commit 8a2e157 into Sylius:master Nov 30, 2016
@pjedrzejewski
Copy link
Member

Thank you Michał!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break PRs introducing BC breaks (do not even try to merge).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants