[Core][Installer] Rework installer commands #6952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
force-pushed
the
rework-installer-commands
branch
from
a3402d3
to
cacdc8d
Compare
Zales0123
changed the title
|
UPDATE: |
michalmarcinkowski
approved these changes
Nov 30, 2016
| $output->writeln(sprintf('Adding <info>%s</info> locale.', $name)); | ||
|
|
||
| $existingLocale = $this->localeRepository->findOneBy(['code' => $this->locale]); | ||
| if (null !== $existingLocale) { |
There was a problem hiding this comment.
We should make sure it's enabled $existingLocale->enable()
| public function setup(LocaleInterface $locale, CurrencyInterface $currency) | ||
| { | ||
| /** @var ChannelInterface $channel */ | ||
| $channel = $this->channelRepository->findOneBy([]); |
There was a problem hiding this comment.
$channel = $repo->findOneBy(['code' => 'default]);
|
Thank you Mateusz, great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sylius installer is a powerful tool, but since last few years it became a little bit messy. This PR is the first step to make it usable.
To-do:
SetupCommandI hope we will be able to test this commands properly in the nearest future, as current test doesn't really test anything ;)