[ProductAssociationType] Fix filtering product association types by name #7143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Dec 21, 2016
GSadee
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Related tickets | fixes after #7134 |
| License | MIT |
lchrusciel
requested changes
Dec 21, 2016
| @@ -0,0 +1,24 @@ | |||
| @managing_product_association_types | |||
| Feature: Filtering product association types | |||
| In order to filter product association types by name or code | |||
There was a problem hiding this comment.
Do we have to be such precise? If new feature would be added should be change also description?
In order to filter product association types
There was a problem hiding this comment.
IMO new feature =~ new file but in this case I agree with you and I will change that
GSadee
force-pushed
the
filtering-product-association-types
branch
from
8fb28b8
to
5ceb608
Compare
lchrusciel
approved these changes
Dec 21, 2016
|
👍 👍 👍 Conclusion, everything needs to be convered! 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.