Polish Behat DataContext file to improve performance #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 2, 2014
Polish Behat DataContext file to improve performance
|
Thanks Joseph! In perfect scenario I'd like to refactor the contexts using PageObjectExtension (see Akeneo), BUT... Behat V3 is coming and not sure how to proceed... :) |
|
@pjedrzejewski Agree we should take a look at Behat v3. We wanted to refactor all the tests with @Arn0d, but as Behat v3 was coming, we waited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed gain is at least 1m (or more, it depends on machine you use + php)