[Locale] Removed enable/disable functionality #7346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Jan 25, 2017
•
NoResponseMate
commented
| Q | A |
|---|---|
| Bug fix? | more of a precaution |
| New feature? | no |
| BC breaks? | yes |
| Related tickets | explained in, closes #7309 |
| License | MIT |
pjedrzejewski
added
the
BC Break
| locale_de: | ||
| code: de | ||
| enabled: false |
There was a problem hiding this comment.
No need to have de locale defined separately anymore.
michalmarcinkowski
approved these changes
Jan 25, 2017
NoResponseMate
force-pushed
the
locale/remove-toggleability
branch
from
067a1bf
to
8154464
Compare
NoResponseMate
force-pushed
the
locale/remove-toggleability
branch
from
8154464
to
2a7a103
Compare
Zales0123
approved these changes
Jan 27, 2017
pamil
suggested changes
Jan 27, 2017
| @@ -59,23 +52,13 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
|
|
|||
| $locale = $event->getData(); | |||
| if ($locale instanceof LocaleInterface && null !== $locale->getCode()) { | |||
| $options['disabled'] = true; | |||
There was a problem hiding this comment.
I guess it shouldn't be removed.
There was a problem hiding this comment.
Went a bit overboard on this one. 👌
lchrusciel
approved these changes
Jan 27, 2017
NoResponseMate
force-pushed
the
locale/remove-toggleability
branch
from
2a7a103
to
1f45982
Compare
GSadee
approved these changes
Jan 30, 2017
|
Thanks Janek! 👍 |
igormukhingmailcom
added a commit
to igormukhingmailcom-forks/Sylius
that referenced
this pull request
Apr 14, 2019
GSadee
pushed a commit
to igormukhingmailcom-forks/Sylius
that referenced
this pull request
Apr 19, 2019
lchrusciel
added a commit
that referenced
this pull request
Apr 19, 2019
This PR was merged into the 1.3 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.3 | Bug fix? | yes | New feature? | no | BC breaks? | not sure (it backward compatible on default fixtures configuration) | Deprecations? | not sure (deprecation messages was added, but not appear on default fixtures configuration) | Related tickets | fixes #10307, partially #7346 | License | MIT So, in BC in mind, with this PR it now will work like this: - **If you have default (empty) configuration, as was before**: ```yaml sylius_fixtures: # ... fixtures: locale: ~ ``` Then, base locale **will be added** to configuration. - *But if you provided a list of locales*: ```yaml sylius_fixtures: suites: my_custom_suite_to_add_to_existing_database: listeners: orm_purger: false fixtures: locale: options: locales: - "de_DE" ``` Then, base locale **will NOT be added** to configuration. Deprecation message was added to avoid usage base locale at all in future. To suppress that message on default configuration, `"%locale%"` was passed directly to the `locales` option at `src/Sylius/Bundle/CoreBundle/Resources/config/app/fixtures.yml`. # TODO - [ ] Define Sylius version where base locale will be removed OR remove deprecation message if base locale should be kept by default (when fixture defined like `locale: ~`) - I'm not 100% sure about this so want to discuss this first. Commits ------- 93f098e Fixed: LocaleFixtureTest as it not valid since #7346 15c0cb7 Avoided: Adding base locale usage to list of fixtures (fixes #10307)
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…eability [Locale] Removed enable/disable functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.