[ResourceBundle] Prevent overriding existing association mappings #7367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the metadata already has existing association mappings for the given field, we won't override anything and leave it as is.
Example:
In our bundle, we define our own product entity and want to add an
order-by
to the association mapping of an existing field. So we copy the field definition fromProduct.orm.xml
to our own configuration and modify it to our needs.The current code will always override our custom association mappings for a given field. So the fix is to check if the field has custom association mappings and only apply them if none are configured.
Also renamed the
hasRelation
method since it's really checking if it is a relation.