[Translations] added translations to admin user form #7431
Conversation
| ->add('firstName', null, [ | ||
| 'label' => 'sylius.ui.first_name' | ||
| ]) | ||
| ->add('lastName', null, [ |
There was a problem hiding this comment.
Shouldn't this and above be TextType::class?
| 'label' => 'sylius.ui.first_name' | ||
| ]) | ||
| ->add('lastName', null, [ | ||
| 'label' => 'sylius.ui.last_name' |
There was a problem hiding this comment.
Missing comma at the end of line. As well as above.
kwedrowicz
force-pushed
the
admin-user-form-locale-fix
branch
from
a200e4b
to
882957f
Compare
|
@Zales0123 , thanks. Improved according to your review. |
| ->add('firstName') | ||
| ->add('lastName') | ||
| ->add('firstName', TextType::class, [ | ||
| 'label' => 'sylius.ui.first_name', |
There was a problem hiding this comment.
We have separate set of translation keys for forms - this should be: sylius.form.admin_user.first_name.
There was a problem hiding this comment.
@pjedrzejewski Are you sure? I see sylius.form.user.first_name but no sylius.form.admin_user.first_name.
There was a problem hiding this comment.
You are right, should be sylius.form.user.first_name. :)
kwedrowicz
force-pushed
the
admin-user-form-locale-fix
branch
from
882957f
to
3414bad
Compare
|
@pjedrzejewski I changed translations according to your comments. Could you rerun travis? The failed test shouldn't have anything in common with my commit. |
|
Restarted the build. |
|
@pjedrzejewski I think this pr is ready now 😄 |
|
Thanks Krzysztof! |
Hi,
it's simple commit adding translations to admin user form (firstName and lastName fields, which was hardcoded earlier).