Fix taxon repository #7437
Fix taxon repository #7437
Conversation
Pitoune
commented
Feb 7, 2017
Pitoune
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Related tickets | fixes #7390 |
| License | MIT |
| @@ -88,7 +88,7 @@ public function findRootNodes() | |||
| */ | |||
| public function findNodesTreeSorted($rootCode = null) | |||
| { | |||
| return $this->createQueryBuilder('o') | |||
| $queryBuilder = $this->createQueryBuilder('o') | |||
There was a problem hiding this comment.
$queryBuilder = $this->createQueryBuilder('o')
// ...
->getQuery()
->getResult()
;Does not look like a fix. 🌮
Pitoune
force-pushed
the
fix-taxon-repository
branch
from
f68516e
to
4117bf3
Compare
|
Anyway, it would be nice to write some tests for this repository, it seems to be a quite tricky part of code :) |
|
Working on it ;) |
|
I did take a look at the tests suite and I am still wondering where to put my test. |
Pitoune
force-pushed
the
fix-taxon-repository
branch
5 times, most recently
from
1cc4b72
to
7686e37
Compare
|
@pamil I finally got time to add some tests ! |
|
Awesome, should be much easier to add them now :) |
|
I have added a backend ajax root to retrieve taxons from the root code. If I need it I guess some others would too. |
|
Can you revert last changes and separate this bug fix from adding a new feature, please? This way we can make the repository method correct and discuss the new feature in another PR. |
|
I am totally OK to do it but without the new feature I cannot find a way to test the |
|
All right, it's the first repository integration test that we want to introduce, so I can write it instead. |
Pitoune
force-pushed
the
fix-taxon-repository
branch
from
7686e37
to
c3f394e
Compare
Pitoune
force-pushed
the
fix-taxon-repository
branch
from
c3f394e
to
e6fabb2
Compare
|
OK so revert is done ;) |
|
Thank you Pierre! 👍 |
