Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation][Cookbook] Disabling order confirmation email #7882

Merged
merged 1 commit into from Apr 11, 2017
Merged

[Documentation][Cookbook] Disabling order confirmation email #7882

merged 1 commit into from Apr 11, 2017

Conversation

CoderMaggie
Copy link
Member

Q A
Doc fix? no
New docs? yes
Related tickets fixes #7763
License MIT

@NoResponseMate
Copy link
Contributor

Pretty sure you can get the same end result with:

sylius_mailer:
    emails:
        order_confirmation:
            enabled: false

@inssein
Copy link
Contributor

inssein commented Apr 3, 2017

@NeverResponse ah totally missed that. That said, I actually do what is suggested in this doc because I send the same email after payment (through the state machine).

@NoResponseMate
Copy link
Contributor

Ah, yes. In that case it is the way to go.

NoResponseMate
NoResponseMate reviewed Apr 3, 2017
View reviewed changes
docs/cookbook/disabling-order-confirmation-email.rst Outdated
}
}

That's it, we have removed the definition of the listnere that is responsible for sending the order confirmation email.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listnere => listener

@pjedrzejewski pjedrzejewski added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Apr 4, 2017
@CoderMaggie CoderMaggie force-pushed the docs/disabling-emails branch 2 times, most recently from 9da239c to d87cd43 Compare April 4, 2017 12:02
@pjedrzejewski pjedrzejewski merged commit 4dd8db8 into Sylius:master Apr 11, 2017
@pjedrzejewski
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoResponseMate NoResponseMate NoResponseMate left review comments

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabling order confirmation email
4 participants
@CoderMaggie @NoResponseMate @inssein @pjedrzejewski